[FLASH-USERS] Bug in Ionize module?

[Suoqing Ji]

Hi,

I’m looking at the Ionize module and suspect there might be a bug in IonizeMain/Eqi/nei.F90 (perhaps this file is out of date). I think the line

xout(jj2) = xout2(i)/selnel

should be

xout(jj2) = xout2(i) * selnel(jj2)

Even from the view of code grammar, selnel is defined as a single real number, but it refers to an array ion_xfrac when nei.F90 is called from Ioinze.F90. In addition, population fraction (xout2) needs to be converted into mass fraction (xout), so the operation here should be multiplication instead of division.

And I have an additional question: if I understood this correctly, the electron population fraction is set to constant in the code (by electron to proton ratio). But even if we can ignore the contribution of metals, helium might not be fully ionized and may make a significant change to electron density. Then why is it valid that electron density remain unchanged throughout ionization?

Thanks in advance!

Best wishes,
--
Suoqing JI
Ph.D Candidate
Department of Physics
University of California, Santa Barbara
http://web.physics.ucsb.edu/~suoqing

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://flash.rochester.edu/pipermail/flash-users/attachments/20161017/c6262f7a/attachment.htm>