<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thank you very much Klaus. Your patch actually did not apply successfully, it says that Hunk #2 Failed at 194.<br><br>However looking at the file, I just took the changes and suggestions you've implied in your e-mail, edited that bit of the code, and it made it through the part of the compilation where it normally stops (as mentioned in my previous e-mail), however right at the end it spit out these errors, saying that the math functions have multiple definitions:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">e.g.</div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">/opt/ibmcmp/xlf/bg/14.1/<wbr>bglib64/libxlfmath.a(math.o): In function `_pow':<br>math.c:(.opd+0x408): multiple definition of `_pow'<br></blockquote><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Surely as a result of my change. Would you suggest I talk to the system admins at this point?</div><br>Thank you for your help.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 30, 2016 at 4:32 PM, Klaus Weide <span dir="ltr"><<a href="mailto:klaus@flash.uchicago.edu" target="_blank">klaus@flash.uchicago.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, 30 Dec 2016, Marissa Adams wrote:<br>
<br>
> mpixlf90_r -I/usr/local/hypre/2.8.0b-MPI-<wbr>XL-No-Global-Partition/include -g<br>
> > -O3 -qnohot -qrealsize=8 -qnosave -qfixed -c -qthreaded<br>
> > -qsuffix=f=F90:cpp=F90 -qfree=f90 -WF,-DFLASH_3T -WF,-DMAXBLOCKS=1000<br>
> > -WF,-DNXB=16 -WF,-DNYB=16 -WF,-DNZB=1 -WF,-DN_DIM=2<br>
> > Diffuse_computeFluxLimiter.F90<br>
> > "Diffuse_computeFluxLimiter.<wbr>F90", line 200.37: 1513-041 (S) Arguments of<br>
> > the wrong type were specified for the INTRINSIC procedure "min".<br>
> > ** diffuse_computefluxlimiter === End of Compilation 1 ===<br>
> > 1501-511 Compilation failed for file Diffuse_computeFluxLimiter.<wbr>F90.<br>
> > make: *** [Diffuse_computeFluxLimiter.o] Error 1<br>
><br>
><br>
> The line in question is:<br>
><br>
> dcoef = min(dcoefOld, fl/(maggrad + 1.0D-100))<br>
<br>
</span>Apply the attached patch (patch -p0 < r25554.diff in the top directory<br>
should do it).<br>
<span class=""><br>
<br>
> It seems to me that min does not like the mixture of two data types:<br>
</span>> variables *dcoefold*, *fl*, *maggrad* being reals, and a double precision<br>
<span class="">> number. I tried converting to and from double precision, and it still<br>
> yields the same error but up upward in the file at line 162.40, which<br>
</span>> doesn't include a *min* at all. Gah!<br>
<br>
<br>
It's a problem because different compilers handle the automatic<br>
propagation of Fortran default REAL to 8-byte REAL differently.<br>
We could make the problem go away for IBM's XLF compiler by replacing<br>
all 'D' exponents in real constants by 'E'. But then some other<br>
compiler complains (for values outside the 4-byte IEEE single<br>
precision real range).<br>
<br>
The approach taken in the patch should work in the maximum number<br>
of compilers.<br>
<span class="HOEnZb"><font color="#888888"><br>
Klaus</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr" style="font-size:12.8px"><font size="1" face="monospace, monospace"><span style="color:rgb(0,0,0)">Marissa Adams <font size="1">E-mail:<a> </a><a href="mailto:madams@pas.rochester.edu" target="_blank">madams@pas.rochester.edu</a></font><br>PhD Student Ph: (585) 402-5779</span></font></div><div dir="ltr" style="font-size:12.8px"><font size="1" face="monospace, monospace"><span style="color:rgb(0,0,0)">University of Rochester Website: <a href="http://www.pas.rochester.edu/~madams/" target="_blank">http://www.pas.rochester.edu/~madams/</a></span></font></div><div dir="ltr" style="font-size:12.8px"><font size="1" face="monospace, monospace"><span style="color:rgb(0,0,0)">Department of Physics & Astronomy</span></font></div><div dir="ltr" style="font-size:12.8px"><font size="1" face="monospace, monospace"><span style="color:rgb(0,0,0)">108 Bausch & Lomb Hall<br>P.O. Box 270171</span></font></div></div></div></div></div></div></div></div>
</div>