<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr">Sean,<div><br></div><div>It appears that your fix is correct and appropriate.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 26, 2020 at 9:40 PM Lewis,Sean <<a href="mailto:scl63@drexel.edu">scl63@drexel.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">





<div lang="EN-US">
<div class="gmail-m_-7314490552192841269WordSection1">
<p class="MsoNormal"><span style="font-size:11pt">Hello FLASH users,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">A combination of setup parameters in FLASH4.6.2 has revealed a compile error.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">The setup call:<u></u><u></u></span></p>
<p class="gmail-m_-7314490552192841269p1"><span class="gmail-m_-7314490552192841269s1">./setup Sedov -auto -3d +usm +gravMgrid</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Will result in the following error:<u></u><u></u></span></p>
<p class="gmail-m_-7314490552192841269p1"><span class="gmail-m_-7314490552192841269s1"><b>hy_uhd_unsplit.F90:1167:80:</b></span><u></u><u></u></p>
<p class="gmail-m_-7314490552192841269p2"><u></u> <u></u></p>
<p class="gmail-m_-7314490552192841269p1"><span class="gmail-m_-7314490552192841269apple-converted-space">      </span><span class="gmail-m_-7314490552192841269s1">call hy_uhd_energyFix(blockID,blkLimits,dt,dtOld,del,hy_eosModeAfter,noMHD=.TRUE.)</span><u></u><u></u></p>
<p class="gmail-m_-7314490552192841269p1"><span class="gmail-m_-7314490552192841269apple-converted-space">                                                                               
</span><span class="gmail-m_-7314490552192841269s2"><b>1</b></span><u></u><u></u></p>
<p class="gmail-m_-7314490552192841269p1"><span class="gmail-m_-7314490552192841269s2"><b>Error:</b></span><span class="gmail-m_-7314490552192841269s1"> Keyword argument '<b>nomhd</b>' at (1) is not in the procedure</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">The error is seemingly corrected by updating source/physics/Hydro/HydroMain/unsplit/hy_uhd_interface.F90, specifically the following lines in the hy_udh_energyFix subroutine declaration:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Menlo">593: subroutine hy_uhd_energyFIx(blockID, blkLimits,dt,dtOld,del,eosMode,<span style="background:lime">rangeSwitch</span>,<span style="background:lime">noMHD</span>)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Menlo">600: integer,OPTIONAL,intent(IN) ::
<span style="background:lime">rangeSwitch</span><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Menlo">601: logical,OPTIONAL,intent(IN) ::
<span style="background:lime">noMHD</span><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">I’d like to confirm that this is a proper fix and if any users or devs expect unforeseen issues stemming from this fix.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Thank you for your help and insights!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">-Sean Lewis<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:11pt;font-family:"Times New Roman",serif;color:black">Sean C. Lewis<u></u><u></u></span></b></p>
<p class="MsoNormal"><span style="font-size:10pt;font-family:"Times New Roman",serif">Doctoral Candidate<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10pt;font-family:"Times New Roman",serif">Department of Physics<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10pt;font-family:"Times New Roman",serif">Drexel University</span><u></u><u></u></p>
</div>
</div>

</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Eddie Hansen, PhD<br>Postdoctoral Associate</div><div>University of Rochester</div><div>607-341-6126 | Flash Center</div></div></div>