[FLASH-BUGS] FLASH 4.2.1: Simple bug in SBlast test problem

[Marko Pavlovic]

Hello everyone!

I'm just starting my work with the FLASH 4.2.1 code and I want to report
a trivial bug but I suppose it can be sometimes annoying. In SBlast test
problem, default initialization source file Simulation_initBlock.F90
has 4 lines with more than 132 characters (maximum allowed by Fortran 90
compiler), so we receive an error during compilation:


---------------------------------------------------------------------------
/usr/bin/mpif90 -ggdb -c -O2 -fdefault-real-8 -fdefault-double-8
-Wuninitialized  -DMAXBLOCKS=1000 -DNXB=8 -DNYB=8 -DNZB=1 -DN_DIM=2
Simulation_initBlock.F90
Simulation_initBlock.F90:163.71:

        if (.not. ((geo.eq.1) .or. (geo.eq.2))) call
Driver_abortFlash("Must us
                                                                       1
Error: Missing ')' in statement at or before (1)
Simulation_initBlock.F90:165.71:

        if (.not. ((geo.eq.3) .or. (geo.eq.4))) call
Driver_abortFlash("Must us
                                                                       1
Error: Missing ')' in statement at or before (1)
Simulation_initBlock.F90:458.132:

sim_rIn) .and. (r_bsw .le. sim_rIn) .and. (r_bse .le. sim_rIn) .and. (r_tne
                                                                           1
Error: Expected a right parenthesis in expression at (1)
Simulation_initBlock.F90:466.132:

t. sim_rIn) .and. (r_bsw .gt. sim_rIn) .and. (r_bse .gt. sim_rIn) .and. (r_
                                                                           1
Error: Expected a right parenthesis in expression at (1)
Simulation_initBlock.F90:465.18:

              else
                  1
Simulation_initBlock.F90:481.21:

                 else
                     2
Error: Duplicate ELSE statements at (1) and (2)
Simulation_initBlock.F90:536.17:

              endif
                 1
Error: Expecting END DO statement at (1)
Simulation_initBlock.F90:537.14:

           endif
              1
Error: Expecting END DO statement at (1)
make: *** [Simulation_initBlock.o] Error 1
--------------------------------------------------------------------------


After breaking this lines to follow 132-character rule, it can be compiled
successfully. I'm sending original source file and changed one.

Cheers,
Marko Pavlovic




 +--------------------------------------+-----------------------------+
 | Marko Pavlovic: marko at matf.bg.ac.rs  |   Department of Astronomy   |
 | ============== or marko at math.rs      |   Faculty of Mathematics    |
 +--------------------------------------+   University of Belgrade    |
 |      Phone: +381 11-2027-827         |   Studentski trg 16         |
 |        Fax: +381 11-2630-151         |   11000 Belgrade, Serbia    |
 +--------------------------------------+-----------------------------+