[FLASH-BUGS] [FLASH-USERS] Patch for FLASH4.5 with HDF5 1.10.x

[Klaus Weide]

On Fri, 18 May 2018, Harris, James Austin wrote:

> I believe this patch is incomplete for parallel HDF5.
> 
> In IOMain/hdf5/parallel/PM/io_h5write_unknowns.c and IOMain/hdf5/parallel/PM/io_h5write_unknowns_sp.c, io_h5_attribute_create and io_h5_attribute_write are being called with (int)*file_identifier (the routines expect const hid_t fileID).
> 
> The fix seems to be to remove the (int) cast and just pass "*file_identifier".
> 
> It looks like this would need to be applied to all of the 
> io_h5write_unknowns.c and io_h5write_unknowns_sp.c files in each 
> sub-unit (IO/IOMain/hdf5/parallel/{NoFbs,UG,PM}). There are also similar 
> problems with NoFbs/io_h5write_facevars.c.

Hi Austin,

I think you are right.

I will work on an updated patch.  Unless you have already created one and 
are willing to share.  :)

Klaus