[FLASH-USERS] Bug in hy_uhd_getFaceFlux

[Dongwook Lee]

Dear James,

Thanks for the correction. I will make this change in the routine.
I will also send out a follow-up email replying to your second email
shortly.

Best regards,
Dongwook

On Thu, Feb 3, 2011 at 5:32 PM, James Guillochon <jfg at ucolick.org> wrote:

> Hi,
>
> There is a bug in hy_uhd_getFaceFlux relating to the "EOSforRiemann" flag.
> There is a variable eosMf that defaults to 1.0 and is never set afterwards,
> when it should be set to the cell averages. This means that as soon as there
> is any mixing this routine is not using the correct mass fractions when
> calling the equation of state.
>
> The fix is easy, simply put this line above all 6 Eos calls (2 for each
> direction), replacing the indices with the appropriate ones that match that
> particular location in the code:
> eosMf = 0.5*(U(SPECIES_BEGIN:SPECIES_END,i,j,k) +
> U(SPECIES_BEGIN:SPECIES_END,i,j,k+1))
>
> Regards,
> - James
>
> --
> James Guillochon
> Department of Astronomy & Astrophysics
> University of California, Santa Cruz
> jfg at ucolick.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://flash.rochester.edu/pipermail/flash-users/attachments/20110204/fd253412/attachment-0001.htm>