[FLASH-USERS] Patch for FLASH4.5 with HDF5 1.10.x

[Harris, James Austin]

Hi,

I believe this patch is incomplete for parallel HDF5.

In IOMain/hdf5/parallel/PM/io_h5write_unknowns.c and IOMain/hdf5/parallel/PM/io_h5write_unknowns_sp.c, io_h5_attribute_create and io_h5_attribute_write are being called with (int)*file_identifier (the routines expect const hid_t fileID).

The fix seems to be to remove the (int) cast and just pass "*file_identifier".

It looks like this would need to be applied to all of the io_h5write_unknowns.c and io_h5write_unknowns_sp.c files in each sub-unit (IO/IOMain/hdf5/parallel/{NoFbs,UG,PM}). There are also similar problems with NoFbs/io_h5write_facevars.c.

--Austin

On 12/22/17, 12:44 PM, "flash-users-bounces at flash.uchicago.edu on behalf of Klaus Weide" <flash-users-bounces at flash.uchicago.edu on behalf of klaus at flash.uchicago.edu> wrote:

    On Wed, 20 Dec 2017, Yingchao Lu wrote:
    
    > Thanks for you update. I tested this patch. It works for the LaserSlab
    > problem with option +hdf5typeio. I checked the data in the output and found
    > no problem.
    
    Thanks Yingchao.
    
    We are now also making the patch available for download. I have added a 
    link and instructions to the FLASH Code user support page here:
    
      http://flash.uchicago.edu/site/flashcode/user_support/
    
    Klaus