[FLASH-USERS] Patch for FLASH4.5 with HDF5 1.10.x

[Harris, James Austin]

Hi Klaus,

I've never made a shareable diff patch, so I hope this works.

Attached the patch in question.

--Austin
________________________________________
From: Klaus Weide <klaus at flash.uchicago.edu>
Sent: Friday, May 18, 2018 6:22 PM
To: Harris, James Austin
Cc: flash-users at flash.uchicago.edu; flash-bugs at flash.uchicago.edu
Subject: Re: [FLASH-USERS] Patch for FLASH4.5 with HDF5 1.10.x

On Fri, 18 May 2018, Harris, James Austin wrote:

> I believe this patch is incomplete for parallel HDF5.
>
> In IOMain/hdf5/parallel/PM/io_h5write_unknowns.c and IOMain/hdf5/parallel/PM/io_h5write_unknowns_sp.c, io_h5_attribute_create and io_h5_attribute_write are being called with (int)*file_identifier (the routines expect const hid_t fileID).
>
> The fix seems to be to remove the (int) cast and just pass "*file_identifier".
>
> It looks like this would need to be applied to all of the
> io_h5write_unknowns.c and io_h5write_unknowns_sp.c files in each
> sub-unit (IO/IOMain/hdf5/parallel/{NoFbs,UG,PM}). There are also similar
> problems with NoFbs/io_h5write_facevars.c.

Hi Austin,

I think you are right.

I will work on an updated patch.  Unless you have already created one and
are willing to share.  :)

Klaus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: FLASH4.5_parallelHDF5.diff
Type: application/octet-stream
Size: 10986 bytes
Desc: FLASH4.5_parallelHDF5.diff
URL: <http://flash.rochester.edu/pipermail/flash-users/attachments/20180519/fdf3cd9b/attachment-0001.obj>